[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Use GtkGridView for albums #480

Draft
wants to merge 9 commits into
base: development
Choose a base branch
from
Draft

WIP: Use GtkGridView for albums #480

wants to merge 9 commits into from

Conversation

HarryMichal
Copy link

An attempt at moving away from FlowBox to GridView for album lists. Has some rough edges (e.g., layout, stylesheet) but is usable enough. Some commits might be needed to be removed as GridView is not usable everywhere.

Is this the way to go?

@HarryMichal
album: Introduce functions for binding to GtkListItem
2e49a07
@HarryMichal
library: Port from FlowBox to GridView
91aa3fe 
GtkGridView requires its immediate parent to be GtkScrolledWindow to
have correct information about available space. Being a child of
GtkOverlay causes the scrolled window to be of the wrong size.
@HarryMichal
saved_playlists: Port from FlowBox to GridView
920a39b 
GtkGridView requires its immediate parent to be GtkScrolledWindow to
have correct information about available space. Being a child of
GtkOverlay causes the scrolled window to be of the wrong size.
@HarryMichal
artist_details: Port from FlowBox to GridView
b099304
@HarryMichal
user_details: Port from FlowBox to GridView
3ed75d1
@HarryMichal
search: Port album results from FlowBox to GridView
cc217c2
@HarryMichal
search: Add missing newline in .ui XML
d66aed7
@HarryMichal
album: Adjust indentation in .ui XML
605451f
@HarryMichal
Add Ondřej Míchal to AUTHORS
64cf5e8
@HarryMichal HarryMichal marked this pull request as draft March 6, 2022 14:51
@xou816
Copy link
Owner
xou816 commented Mar 11, 2022

Hi! Sorry for the slow response. This sounds like a nice improvement! I'll check out that branch and have a look. Thnaks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarryMichal @xou816