Update Membership Routes #2511
Merged
Update Membership Routes #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
978672c
to
0d9172f
Compare
e94efd7
to
5193232
Compare
a93b849
to
787216a
Compare
Merged
gbirke
reviewed
Jul 6, 2022
|
There were some recent payment changes (checking allowed payment types) that might affect how the controllers for applying for membership and validating the fee construct classes. Please review #2515 and merge it, rebasing this PR on top of it |
373f4aa
to
396a9a7
Compare
gbirke
requested changes
Jul 14, 2022
876de2d
to
f6f89fe
Compare
Integrate payment context changes into this controller and presenter Ticket: https://phabricator.wikimedia.org/T309088
This adds a unique prefix to DD transfer codes in preparation for https://phabricator.wikimedia.org/T312087 Ticket: https://phabricator.wikimedia.org/T309088
Implements new payment domain changes Ticket: https://phabricator.wikimedia.org/T309088 This also removes the account number and bank code and closes https://phabricator.wikimedia.org/T224220
Implement changes from the new payment domain Ticket: https://phabricator.wikimedia.org/T309088
Implement new payment domain changes Ticket: https://phabricator.wikimedia.org/T309088
Currently, the frontend does not send a payment type (because until we implement https://phabricator.wikimedia.org/T312070 we have only one payment type), but the new payment domain requires a payment type when validating (because it's trying to construct a valid Payment internally). This problem only occurs in the fee validation. For applying for memberships the frontend sends a type. For donations we don't have server-side validation of the amount.
493252e
to
07e472e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate payment context changes into this
controller and presenter
Ticket: https://phabricator.wikimedia.org/T309088