Upgrade prom-client from ^11.5.3 to ^12.0.0 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12.0.0 provides GC metrics which are wanted for various uses. The breaking changes are mostly the dropping of support for Node 6 and 8, which don't affect us, removal of deprecated constructor use, and change in how default metrics are now collected, which aren't currently used: https://github.com/siimon/prom-client/releases/tag/v12.0.0 https://phabricator.wikimedia.org/T350180
gmodena
reviewed
Feb 28, 2024
| @@ -43,7 +43,7 @@ | |||
| "js-yaml": "^3.13.1", | |||
| "limitation": "^0.2.3", | |||
| "lodash.clonedeep": "^4.5.0", | |||
| "prom-client": "^11.5.3", | |||
| "prom-client": "^12.0.0", | |||
There was a problem hiding this comment.
The latest version is 15.1.0. Should we be bold and aim for that?
There was a problem hiding this comment.
There are a bunch of other breaking changes, and no tests, so I was trying to be conservative in the upgrade.
gmodena
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12.0.0 provides GC metrics which are wanted for various uses.
The breaking changes are mostly the dropping of support for Node 6 and 8, which don't affect us, removal of deprecated constructor use, and change in how default metrics are now collected, which aren't currently used:
https://github.com/siimon/prom-client/releases/tag/v12.0.0
https://phabricator.wikimedia.org/T350180