[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup maki7 #6

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Cleanup maki7 #6

merged 2 commits into from
Aug 23, 2022

Conversation

adamwight
Copy link
Collaborator

No description provided.

thiemowmde
thiemowmde approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator
@thiemowmde thiemowmde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. 👍 Contrast is often much better with this threshold.

@adamwight adamwight force-pushed the cache-all branch 4 times, most recently from 8e647b8 to d3c810c Compare August 23, 2022 13:17
@adamwight
Tweak contrast threshold to value found using the APCA algorithm
ac5e6b9 
This switches to dark fills only once the background is much lighter
than before, roughly at #a7a7a7.
@adamwight
Map alternate park old name to new name
a4032ac 
Note that the tree type is flipped between versions, but we'll trust
that the map author's intention is usually "recognizable icon for
park" rather than a specific tree species.
Base automatically changed from cache-all to master August 23, 2022 13:26
@thiemowmde thiemowmde merged commit 60bb0d4 into master Aug 23, 2022
@thiemowmde thiemowmde deleted the cleanup-maki7 branch August 23, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiemowmde thiemowmde thiemowmde approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamwight @thiemowmde