[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talk pages - iPad tweaks #4364

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Talk pages - iPad tweaks #4364

merged 5 commits into from
Oct 27, 2022

Conversation

tonisevener
Copy link
Collaborator
@tonisevener tonisevener commented Oct 14, 2022 •
edited
Loading

Phabricator:
N/A, but called this PR out in https://phabricator.wikimedia.org/T310275#8317922.

Notes

This is a PR to align a few more things to the readableContentGuide, so that iPad content lines up with the header.

I also added a final commit to adjust the full-screen coffee roll so that the scroll indicator appears on the edge. This is more of a personal preference - happy to revert if there's pushback.

Test Steps

  1. Review topic cells, full screen coffee roll and empty state on iPad and iPhone. Confirm there are no layout issues.

Screenshots/Videos

Before:
B4bID
After:
HQn7e

Before:
tRdEm
After:
763YE

Before:
ODQKg
After:
aD1GR

Before:
QBP1s
After:
OnpdE

@tonisevener tonisevener requested review from a team and staykids and removed request for a team October 14, 2022 21:23
@mazevedofs mazevedofs requested review from mazevedofs and removed request for staykids October 26, 2022 18:10
@mazevedofs mazevedofs self-assigned this Oct 26, 2022
mazevedofs
mazevedofs requested changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator
@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just confirming that this is the intended layout for the button (or should the text have as much padding as the button?)

IMG_0010

@tonisevener
Copy link
Collaborator Author

Looking good, just confirming that this is the intended layout for the button (or should the text have as much padding as the button?)

IMG_0010

Good catch! I'm not sure on this one. I asked design in the Phab task so we'll see what they say.

@mazevedofs mazevedofs merged commit c7dc678 into main Oct 27, 2022
@mazevedofs mazevedofs deleted the talk-pages/ipad-tweaks branch October 27, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs mazevedofs approved these changes

Assignees

@mazevedofs mazevedofs

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonisevener @mazevedofs