[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Xcode 12 #3646

Merged
merged 49 commits into from
Aug 20, 2020
Merged

Updates for Xcode 12 #3646

merged 49 commits into from
Aug 20, 2020

Conversation

joewalsh
Copy link
Contributor
@joewalsh joewalsh commented Jul 30, 2020 •
edited
Loading

Fixes

https://phabricator.wikimedia.org/T259649

Notes

  • As of Xcode 12 beta 4, there's a blocking iOS 14 simulator-only bug where articles take an excessively long time to load. The app gives thewebView a URLRequest and there's a long pause (10+ seconds) before the webView makes the request. The issue persists if the custom scheme handler is removed and the request is made with https as the scheme. iOS < 14 simulators and devices work. This is fixed in Xcode 12 beta 5
  • Fixed an iPad crash with 1f7d04c
  • Cleared view debugger warnings and fixed unresponsive explore feed cells in c00a5b2...97fa10b

Test Steps

  1. Build and run using the latest version of Xcode 12
  2. Verify there are zero warnings
  3. Verify articles, non-article pages, and editors load and work correctly

@joewalsh joewalsh added the Hold label Jul 30, 2020
@joewalsh joewalsh added this to the 6.7 milestone Jul 30, 2020
@staykids
Copy link
Contributor

Just an FYI, I'm rebasing my WidgetKit work off this branch. It's not a big deal though if this branch get mutated wildly or even deleted – for the most part that work is fairly portable.

@tonisevener tonisevener self-assigned this Aug 11, 2020
tonisevener
tonisevener reviewed Aug 12, 2020
View reviewed changes
Wikipedia/Wikipedia-Info.plist Outdated
@@ -65,6 +67,7 @@
<key>UIBackgroundModes</key>
<array>
<string>fetch</string>
<string>processing</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joewalsh Just curious as to your reasons for adding this - I see an error on the build server log with ""Missing Info.plist value. The Info.plist key 'BGTaskSchedulerPermittedIdentifiers' must contain a list of identifiers used to submit and handle tasks when 'UIBackgroundModes' has a value of 'processing'. For more information, refer to the Information Property List Key Reference at https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Introduction/Introduction.html.""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue with WKWebView without it but that was a few betas ago. I'll remove it and see if the error persists. If it does, there's a BackgroundTasks branch that converts our background fetch to a background task and adds the appropriate identifier that we could incorporate.

@joewalsh joewalsh removed the Hold label Aug 18, 2020
@tonisevener tonisevener removed their assignment Aug 18, 2020
@joewalsh joewalsh merged commit 3a900e8 into main Aug 20, 2020
@joewalsh joewalsh deleted the xcode-12-beta branch August 20, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@joewalsh @staykids @tonisevener