Secp256k1 js #28
Open
Secp256k1 js #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm not a crypto expert so this is a humble attempt to replace openssl with js
I've deleted csr_template.ts file since csr config is not a template now, this can be reverted if you prefer to
in sign I had to replace crypto createSign with jsrsasign sign method as the current solution couldn't parse privatekey generated by jsrsasign most likely due to the new line added being \r\n not \n
anyway this can be reverted if we use a another library to create keys, I tried ecdsa-secp256r1 and it worked without any modification to the original signing functions
@fidm/x509 module can be replaced with jsrsasign - no need for 2 deps
sorry for some of the unrelated changes, it's just my editor removing extra white spaces, maybe we should use a code formatter 😝