Use pyramid.csrf independent API #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove CSRF related code from session * use default get_csrf_token() function in templates * update CSRF validator for deform2 * use token functions directly (request.session.* -> pyramid.csrf.*)
By default Pyramid 1.10 still use `LegacySessionCSRFStoragePolicy`
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 78.64% 78.63% -0.02%
==========================================
Files 133 133
Lines 5803 5800 -3
Branches 627 626 -1
==========================================
- Hits 4564 4561 -3
Misses 997 997
Partials 242 242
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 78.64% 78.63% -0.02%
==========================================
Files 133 133
Lines 5803 5800 -3
Branches 627 626 -1
==========================================
- Hits 4564 4561 -3
Misses 997 997
Partials 242 242
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #211
SessionCSRFStoragePolicy(store token in session)It's break some
request.session.get_csrf_token()calls, now you must use standardget_csrf_token()(that available in templates too). About backward compability - i don't think that it really needed, websauna is still in alfa and upgrading to new API is trivial task.TODO: update websauna.magiclogin, blog and check other apps.