Blob constructor 'endings' options #8456
Conversation
|
Note that we shouldn't merge this until:
|
Build PASSEDStarted: 2017-11-29 20:28:13 View more information about this build on: |
|
Needs cases for newlines split across strings, i.e. |
|
(FWIW, looks great thus far.) |
There was a problem hiding this comment.
Agreed with @annevk that we of course need the spec text and File constructor tests as well. I'll have a go at spec text tomorrow, if nobody else beats me to it.
| JSON.stringify(value)); | ||
| }); | ||
|
|
||
| const test_error = {name: 'test', message: 'test error'}; |
There was a problem hiding this comment.
Having anything other than a name in here is a bit pointless, as assert_throws only checks the name anyway.
There was a problem hiding this comment.
Done. (copied from Blob-constructor.html, but leaving it alone there)
| } | ||
|
|
||
| test(function() { | ||
| [ |
There was a problem hiding this comment.
I think I slightly prefer if each of these cases was their own test, rather than having them be assertions in one combined test, but this is fine too.
|
Spec in w3c/FileAPI#90 |
Done.
Done. |
|
What's going on with the edge results for these anyway, somehow none of the tests are getting run and instead a "top-level" failure of "Expected ')'" is reported? |
Well, I'm guessing that is a problem with the WPT infra, running these locally in edge seems to work fine (and shows that edge indeed completely ignores the endings attribute). |
|
Thanks for reviewing/merging! Also thanks for trying out in Edge — I hadn't run these in any other browser yet. As noted in w3c/FileAPI#46 Edge should parse the attribute but ignore it. @aliams - do you need a bug or do you have one already? |
Tests for the 'endings' options for the Blob and File constructor.
w3c/FileAPI#46