[css2][css-fonts] Tests to go with https://github.com/w3c/csswg-drafts/pull/1993 #8448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These match with the spec changes in w3c/csswg-drafts#1993 regarding the line-height property. The odd numbering starting at 201 rather that 001 is to avoid clashing with existing similarly named tests.
These match with the spec changes in w3c/csswg-drafts#1993 regarding the height of the content area of inline boxes.
These test whether the the ex and ch units correctly depend on the first font **that contains U+0020**, rather than the first font at all. This matches the resolution from w3c/csswg-drafts#1765, and the spec pull request in w3c/csswg-drafts#1993
These test whether the line-height calculations define in CSS2.1 correctly depend on the first font **that contains U+0020**, rather than the first font at all. This matches the resolution from w3c/csswg-drafts#1798, and the spec pull request in w3c/csswg-drafts#1993
This tests whether the inline box content height calculations defined in CSS2.1 correctly depend on the first font **that contains U+0020**, rather than the first font at all. This matches the resolution from w3c/csswg-drafts#1798, and the spec pull request in w3c/csswg-drafts#1993
Build PASSEDStarted: 2017-11-27 10:29:41 Failing Jobs
Unstable ResultsBrowser: "Microsoftedge 14.14393" (failures allowed)View in: WPT PR Status | TravisCI
|
svgeesus
approved these changes
Dec 1, 2017
|
Thanks. I expected the merge for the tests and the PR to happen at roughly the same time. Now that the tests are merged it, we should merge in the spec part as well before long. Can you help me nudge the editor (Bert) and the other people who should review that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w3c/csswg-drafts#1993 fixed / improved some definitions of line-height, the height of the content area of inline boxes, and of first-available font.
These are the tests to go with that spec PR.