Add tests using Request/fetch similar to the XHR ones added in #4953 #7848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@annevk does my understanding here match yours? |
Build PASSEDStarted: 2017-11-30 14:47:33 Failing Jobs
View more information about this build on: |
annevk
approved these changes
Oct 25, 2017
|
This is approved, is there any reason why it isn't merged? (Had CI not finished when it was approved?) |
|
The reason I didn't merge it is because I asked questions. It's easier to get questions answered if something isn't marked as resolved. |
b0c5490
to
af1c898
Compare
|
Sorry for the delay, I somehow missed the earlier approval/comments. Added a test passing url directly to fetch(). Haven't filed any implementation bugs, no, as I wasn't sure this was actually the behavior we want to specs to describe. But I think I now agree that it probably is the right behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the Request spec has the same behavior where on creating the Request we're supposed to parse the URL and get a reference to the underlying blob, and as such this test is supposed to pass.