Handle disabling zerotouch for some vEOS versions #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanisyako
reviewed
Nov 21, 2021
veos/docker/launch.py
Outdated
| self.disable_zerotouch = False | ||
|
|
||
| # list of images that require us to disable zerotouch for proper function | ||
| requires_zerotouch_disable = ['vEOS-lab-4.27.0F.vmdk'] |
There was a problem hiding this comment.
I'm inclined to agree. Shouldn't we generally turn this off?
Is there a downside to always turning it off? Seems like the simpler thing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of vEOS requires disabling zerotouch before it functions as expected.