[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style management changes #566

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

squidink7
Copy link

This PR reworks the way styles are handled by controls throughout the window.

The initial motivation was to add a simple way to switch themes at runtime, which in itself was simple enough but I wanted a way to allow individual widgets to have their own style rather than overriding them all each time the window's theme changed.

This makes it so each widget's theme_style field is empty unless explicitly set, and when rendering it uses the theme set on the window unless otherwise specified.
Previously V UI set the theme_style across all widgets when the window is created.

I haven't thoroughly tested each example yet, and in absence of unit tests have been basing this work on a sample app of my own which doesn't use anywhere near every control available, so oversights may be present. I apologise if any have slipped through.

@spytheman
Copy link
Member

@rcqls what do you think?

@rcqls
Copy link
Collaborator
rcqls commented Feb 18, 2024

@rcqls what do you think?

I'll have a look very soon....

@squidink7 squidink7 force-pushed the theme_management branch 2 times, most recently from 078abad to be4df07 Compare June 17, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants