[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove ssrError when invalidating a module #8124

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: remove ssrError when invalidating a module #8124

merged 1 commit into from
May 11, 2022

Conversation

matthewp
Copy link
Contributor

Description

This removes ssrError when invalidating a module from the graph (which happens when a module is changed).

Additional context

This is a follow up to #8052 which partially fixed the problem.

This fixes a bug in Astro: withastro/astro#3263

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@matthewp matthewp mentioned this pull request May 11, 2022
Merged
9 tasks
@bluwy bluwy changed the title fix: Remove ssrError when invalidating a module fix: remove ssrError when invalidating a module May 11, 2022
@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels May 11, 2022
@patak-dev patak-dev merged commit a543220 into vitejs:main May 11, 2022
@matthewp matthewp deleted the invalidate-ssr-error3 branch May 11, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewp @patak-dev @bluwy