ex: fix newline escaping #15120
Closed
ex: fix newline escaping #15120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2de90ca
to
3b2435a
Compare
3b2435a
to
0f6a29c
Compare
This fixes newline escaping to allow passing multiple commands to ":global", multiple lines to shell commands, and ending lines in append mode with backslashes. This reverts a previous incorrect attempt to fix append mode which removed half of trailing backslashes which lead to, eg. the following two commands being parsed as having a different number of backslashes: ``` !echo foo\\\ ``` ``` !echo foo\\ \ ```
0f6a29c
to
7436b76
Compare
|
The fix for this turned out to be much simpler. The culprit was 417f5e7, so ex mode has been broken for around 14 years... |
|
Thanks! |
|
Does this just revert 7.3.014? |
|
It is resolved. We fix it correctly by not interpreting backslashes at all in insert mode. |
mohd-akram
added a commit
to mohd-akram/vim
that referenced
this pull request
Jul 7, 2024
related: vim#15120 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com>
mohd-akram
added a commit
to mohd-akram/vim
that referenced
this pull request
Jul 7, 2024
related: vim#15120 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com>
|
It's not completely reverted, there is an added check for There were some discussions around 7.3.014: https://groups.google.com/g/vim_dev/c/F5-tDqoafz8/m/GqKF-uQsLD0J The example mentioned in this thread: This works now correctly. Should probably turn this into a test as well. |
chrisbra
added a commit
that referenced
this pull request
Jul 7, 2024
Problem: Not enough tests for what v9.1.0535 fixed Solution: Add another test for ex-mode This comes from: https://groups.google.com/g/vim_dev/c/F5-tDqoafz8/m/GqKF-uQsLD0J related: #15120 Signed-off-by: Christian Brabandt <cb@256bit.org>
RestorerZ
pushed a commit
to RestorerZ/fork_vim-orig
that referenced
this pull request
Jul 9, 2024
Problem: newline escape wrong in ex mode (Konrad Schwarz)
Solution: partly revert patch 7.3.014, remove backslash in front of a
newline when not in prompt mode in ex line mode
(Mohamed Akram)
This fixes newline escaping to allow passing multiple commands to
":global", multiple lines to shell commands, and ending lines in append
mode with backslashes. This should fix a POSIX/(traditional) VI
incompatiblity.
This reverts a previous incorrect attempt at patch v7.3.014 to fix
append mode which removed half of trailing backslashes which lead to,
eg. the following two commands being parsed as having a different number
of backslashes:
```
!echo foo\\\
```
```
!echo foo\\ \
```
fixes: vim#6135
fixes: vim#7244
closes: vim#15120
Signed-off-by: Mohamed Akram <mohd.akram@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
RestorerZ
pushed a commit
to RestorerZ/fork_vim-orig
that referenced
this pull request
Jul 9, 2024
Problem: Not enough tests for what v9.1.0535 fixed Solution: Add another test for ex-mode This comes from: https://groups.google.com/g/vim_dev/c/F5-tDqoafz8/m/GqKF-uQsLD0J related: vim#15120 Signed-off-by: Christian Brabandt <cb@256bit.org>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Jul 12, 2024
related: vim/vim#15120 closes: vim/vim#15228 vim/vim@74703f1 Co-authored-by: Mohamed Akram <mohd.akram@outlook.com>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Jul 12, 2024
related: vim/vim#15120 closes: vim/vim#15228 vim/vim@74703f1 Nvim only supports Vim Ex mode, so this is long obsolete in Nvim. Co-authored-by: Mohamed Akram <mohd.akram@outlook.com>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Jul 12, 2024
…29678) related: vim/vim#15120 closes: vim/vim#15228 vim/vim@74703f1 Nvim only supports Vim Ex mode, so this is long obsolete in Nvim. Co-authored-by: Mohamed Akram <mohd.akram@outlook.com>
mohd-akram
added a commit
to mohd-akram/vim
that referenced
this pull request
Jul 13, 2024
related: vim#15120 Signed-off-by: Mohamed Akram <mohd.akram@outlook.com>
github-actions bot
pushed a commit
to neovim/neovim
that referenced
this pull request
Jul 14, 2024
…29678) related: vim/vim#15120 closes: vim/vim#15228 vim/vim@74703f1 Nvim only supports Vim Ex mode, so this is long obsolete in Nvim. Co-authored-by: Mohamed Akram <mohd.akram@outlook.com> (cherry picked from commit 10256bb)
zeertzjq
pushed a commit
to neovim/neovim
that referenced
this pull request
Jul 14, 2024
…29702) related: vim/vim#15120 closes: vim/vim#15228 vim/vim@74703f1 Nvim only supports Vim Ex mode, so this is long obsolete in Nvim. Co-authored-by: Mohamed Akram <mohd.akram@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes newline escaping to allow passing multiple commands to ":global", multiple lines to shell commands, and ending lines in append mode with backslashes. This reverts a previous incorrect attempt to fix append mode which removed half of trailing backslashes which lead to, eg. the following two commands being parsed as having a different number of backslashes:
Fixes #6135
Fixes #7244
@konrad-schwarz