fix: preserve Check options in schema statistics roundtrip #1844
+385
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
===========================================
- Coverage 94.28% 59.05% -35.23%
===========================================
Files 91 120 +29
Lines 7013 9229 +2216
===========================================
- Hits 6612 5450 -1162
- Misses 401 3779 +3378 ☔ View full report in Codecov by Sentry. |
|
@alexismanuel looks like there are some failing unit tests |
Signed-off-by: alexismanuel <alexis.manuelpro@gmail.com>
9b5e30f
to
d09f3d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: preserve Check options in schema statistics roundtrip (#694)
What does this PR do?
Fixes #694 by ensuring check options (like
raise_warningandignore_na) are preserved when schemas are serialized and deserialized.Changes
parse_checksto include check options in statisticsparse_check_statisticsto reconstruct checks with their original optionsTesting
Updated existing test cases in test_schema_statistics.py to verify options persistence
All tests passing locally
All pre-commit are passing
No new warnings introduced
Related Issues
Closes #694
Let me know if you need any additional information or would like me to make any adjustments.