[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use int32 as default int representation in windows #1179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

use int32 as default int representation in windows #1179

wants to merge 2 commits into from

Conversation

cosmicBboy
Copy link
Collaborator

fixes #726

@cosmicBboy
test default windows int
7a80419 
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@codecov
Copy link
codecov bot commented May 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.20 ⚠️

Comparison is base (a057df0) 97.23% compared to head (7a80419) 97.03%.

❗ Current head 7a80419 differs from pull request most recent head 93eadaa. Consider uploading reports for the commit 93eadaa to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
- Coverage   97.23%   97.03%   -0.20%     
==========================================
  Files          65       65              
  Lines        5067     5067              
==========================================
- Hits         4927     4917      -10     
- Misses        140      150      +10
Impacted Files Coverage Δ
pandera/engines/pandas_engine.py 95.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cosmicBboy cosmicBboy mentioned this pull request May 7, 2023
Open
@cosmicBboy
wip
93eadaa 
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy changed the title test default windows int use int32 as default int representation in windows May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default int type should be mapped to Int32 in Windows
1 participant
@cosmicBboy