Add support for ipv6 subnet in ipStrategy #9747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR. |
|
Hello @michal-kralik, Thanks a lot for this contribution! I have pushed some commits from review, to add docs, and also rebase the changes to be up to date with the target branch. |
|
🚫 the milestone is missing |
086b3f7
to
d7d72b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for grouping IPv6 address into a single IP of the defined subnet.
This is useful in
RateLimitandInFlightReqmiddlewares where it's easy to bypass any filtering by changing to a new IPv6.Closes #9721
Motivation
Community contribution
More
Additional Notes
Since I'm new to Traefik, it's not clear if this is the right place to configure this setting.
It's on
ipStrategy.ipv6Subnetlevel. It works fine withRateLimitandInFlightReqbut not withIpWhitelist.It may make more sense on the middleware level, but since it's applicable only when the
sourceCriterionis IP, it's ideal either.Happy to change the implementation according to what's preferred.