Add upload-artifact to build script #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyans Jain <shreyansthebest2007@gmail.com> Fix upload-artifact Signed-off-by: Shreyans Jain <shreyansthebest2007@gmail.com> Try to fix upload-artifact again Signed-off-by: Shreyans Jain <shreyansthebest2007@gmail.com> Fix name in upload-artifact Signed-off-by: Shreyans Jain <shreyansthebest2007@gmail.com>
|
@DestroyerXyz This looks like it uploads artifacts for every commit on PR and merge. Wouldn't that get noisy? |
|
It says inside the action, does not create a release or something. |
Signed-off-by: Shreyans Jain <shreyansthebest2007@gmail.com>
|
Added build for multiple platforms. |
tkellogg
approved these changes
Jan 10, 2022
|
Excellent, thanks for taking over on this. I had plan to do it, but got busy with life and work lately. |
|
You're welcome |
|
@tkellogg BTW, you can add [skip ci] to the beginning of a commit to skip ci like if updating the README for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will upload the compiled binary to Github actions.