[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying engine files (based on #153) #154

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Fix copying engine files (based on #153) #154

merged 1 commit into from
Apr 5, 2022

Conversation

mre
Copy link
Member
@mre mre commented Mar 25, 2022

Might be a fix for #152, #151, #147.
Would be delighted if someone could test this.

@mre
Copy link
Member Author
mre commented Mar 25, 2022

All credits go to shijunti19.

@robinkloeckner
Copy link

I am not experienced in working with Rust and Cargo, but I have tested it the following way on macOS 12.2.1 with cargo 1.59.0 and rust 1.56.1 and it worked.

ts-pr154-1

ts-pr-154-2

ts-pr-154-3

Hope this helps.

@mre
Copy link
Member Author
mre commented Apr 5, 2022

Alright! I'll go ahead and merge this then. This is the feedback I was hoping for. Thanks a lot @robinDotDev. 🥳

@mre mre merged commit e00555d into master Apr 5, 2022
@mre mre deleted the fix-engine-copy branch April 5, 2022 09:50
@mre
Copy link
Member Author
mre commented Apr 5, 2022

Hum... the CI build was failing after the merge.

@robinkloeckner
Copy link

Copy. It is due to the Docker Image build, if I am right? Unfortunately I am not experienced with Docker in order to evaluate this issue.

@ardeaf
Copy link
ardeaf commented Jul 31, 2022

Any updates and any way I can help with this?

@mre
Copy link
Member Author
mre commented Aug 3, 2022

The issue should be resolved and the CI build is green again. Are there still any problems?

@ardeaf
Copy link
ardeaf commented Aug 6, 2022

The issue should be resolved and the CI build is green again. Are there still any problems?

I thought I was having issues but it was just with the version on crates.io. When I specified to install from git, it works flawlessly.

@mre
Copy link
Member Author
mre commented Aug 6, 2022

Oh. Published 0.6.4 with the fix to crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants