[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poster frame for videos #29

Open
aaronpk opened this issue Sep 22, 2017 · 1 comment
Open

poster frame for videos #29

aaronpk opened this issue Sep 22, 2017 · 1 comment
Labels
Postponed (revisit in future effort) Waiting for Commenter

Comments

@aaronpk
Copy link
Collaborator
aaronpk commented Sep 22, 2017

Right now the spec says if an h-entry contains a video, then it's a video post. In practice, there are often h-entrys with both a video and photo property, where the photo is intended to be the poster frame of the video. This also serves as a fallback for consumers that don't know about videos.

It'd be useful for the spec explicitly say how to handle poster images, and what to do when there is a photo property in addition to the video property.

The way I've been explaining it is:

if there is a single value for both the video and photo properties, the photo is a poster frame for the video
@tantek
Copy link
Owner
tantek commented Dec 19, 2017

I think this is a good improvement and makes sense.

I also think "poster frame detection" could be a video-type-specific algorithm that could be specified independently rather than confounding the return value(s) of Post Type Discovery.

I suggest brainstorming this on the indieweb wiki, perhaps as indieweb.org/poster-frame-discovery and normatively referencing Post Type Discovery for first determining that a post is a video post.

Suggest closing without any changes to this spec.

aaronpk pushed a commit to indieweb/wiki that referenced this issue Aug 24, 2018
Zegnat added "[tantek/post-type-discovery#29 Initial discussion of po…
05f011e 
…ster frame discovery] as part of [[PTD]]" to "See Also"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Postponed (revisit in future effort) Waiting for Commenter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tantek @aaronpk