[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable external urls #29

Merged

Conversation

torsten-bit
Copy link
Contributor

Hi,

first of all, thank you for making working with AXE and HtmlCS so easy.

We run accessibility-tests within our new build-environment which does not have access to the internet. Therefore we would like to get the js-scripts from another server. I made the urls configurable, defaulting to the current behavior.

Kind regards
Torsten

@torsten-bit
Copy link
Contributor Author

Seems to me that the codacy api token is missing or maybe outdated?

@sridharbandi
Copy link
Owner

@torsten-bit

Does this work around works for you ? #26 (comment)

@torsten-bit
Copy link
Contributor Author

Hi @sridharbandi. yes this would work, but it seems to be a lot of manual effort to get it working. Moreover we would not benefit from any future updates. Therefore we would like to have a way to customize the injection of the resources.

@sridharbandi
Copy link
Owner

Hi @sridharbandi. yes this would work, but it seems to be a lot of manual effort to get it working. Moreover we would not benefit from any future updates. Therefore we would like to have a way to customize the injection of the resources.

@torsten-bit I will test the changes and will create a release in couple of days.
Thank you for your contribution.

@torsten-bit
Copy link
Contributor Author

I just found a small typo and fixed that.

@sridharbandi sridharbandi merged commit 8ea9089 into sridharbandi:master Apr 1, 2023
@sridharbandi
Copy link
Owner

@torsten-bit created release v3.0.4. Thank you for your contribution 👍 . Star it if you find this project useful, and share it in your QA circle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants