Disable admin preview for extensions test apps #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new admin is far from complete and existing extensions will fail if we test them with the new default admin that we generate apps with. It can be enabled by setting ADMIN_PREVIEW=true in your test env.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5600 +/- ##
==========================================
- Coverage 88.58% 88.57% -0.01%
==========================================
Files 685 685
Lines 16404 16405 +1
==========================================
Hits 14531 14531
- Misses 1873 1874 +1 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Jan 17, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new admin is far from complete and existing
extensions will fail if we test them with the
new default admin that we generate apps with.
It can be enabled by setting
ADMIN_PREVIEW=truein your test env.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: