[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Order adjustments #5513

Merged
merged 8 commits into from
Jan 11, 2024
Merged

[admin] Order adjustments #5513

merged 8 commits into from
Jan 11, 2024

Conversation

elia
Copy link
Member
@elia elia commented Nov 16, 2023 •
edited
Loading

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 16, 2023
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin labels Nov 16, 2023
@elia elia force-pushed the elia/admin/order-adjustments branch 3 times, most recently from 9046f7e to f9561b9 Compare November 20, 2023 18:29
@github-actions github-actions bot added the changelog:solidus_sample Changes to the solidus_sample gem label Nov 20, 2023
@elia elia force-pushed the elia/admin/order-adjustments branch from f9561b9 to 676bee5 Compare November 22, 2023 15:16
@github-actions github-actions bot removed the changelog:solidus_sample Changes to the solidus_sample gem label Nov 22, 2023
@elia elia force-pushed the elia/admin/order-adjustments branch 2 times, most recently from 1b37844 to 51dae23 Compare November 27, 2023 17:39
@elia elia force-pushed the elia/admin/order-adjustments branch from 51dae23 to e9efa1e Compare December 11, 2023 16:44
@elia elia force-pushed the elia/admin/order-adjustments branch 2 times, most recently from 8ea4025 to b347584 Compare January 9, 2024 11:02
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jan 9, 2024
@elia elia force-pushed the elia/admin/order-adjustments branch from b347584 to d007ef7 Compare January 9, 2024 11:43
@codecov Codecov
Copy link
codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (bb39b3f) 88.65% compared to head (941f420) 88.58%.

Files Patch % Lines
...s_admin/orders/show/adjustments/index/component.rb 74.32% 19 Missing ⚠️
...lib/generators/spree/dummy/templates/rails/test.rb 0.00% 6 Missing ⚠️
...mponents/solidus_admin/ui/pages/index/component.rb 90.00% 2 Missing ⚠️
core/lib/spree/testing_support/dummy_app.rb 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5513      +/-   ##
==========================================
- Coverage   88.65%   88.58%   -0.08%     
==========================================
  Files         683      685       +2     
  Lines       16293    16402     +109     
==========================================
+ Hits        14445    14529      +84     
- Misses       1848     1873      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elia elia force-pushed the elia/admin/order-adjustments branch 3 times, most recently from b5e21ff to 2d4250d Compare January 10, 2024 10:23
@elia elia requested a review from rainerdema January 10, 2024 15:55
@elia elia marked this pull request as ready for review January 10, 2024 16:15
@elia elia requested a review from a team as a code owner January 10, 2024 16:15
@elia elia force-pushed the elia/admin/order-adjustments branch from 2d4250d to 373f722 Compare January 11, 2024 11:01
@elia elia force-pushed the elia/admin/order-adjustments branch from 373f722 to 941f420 Compare January 11, 2024 15:14
rainerdema
rainerdema approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor
@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@elia elia merged commit 12d7504 into main Jan 11, 2024
12 of 14 checks passed
@elia elia deleted the elia/admin/order-adjustments branch January 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema