Fix #242 and #303 by internally using ReplaySubject for intents

sockeqwe · Mar 3, 2018 · 0b97c26 · 0b97c26
1 parent 3c8f8f8
commit 0b97c26
Show file tree

Hide file tree

Showing 12 changed files with 614 additions and 459 deletions.
diff --git a/build.gradle b/build.gradle
@@ -49,6 +49,7 @@ ext {
   // Libraries
   supportLibVersion = '27.0.2'
   rxjava2Version = '2.0.7'
+  rxAndroid2Version = '2.0.1'
 
 
   // Libraries for samples

diff --git a/mvi-common/src/main/java/com/hannesdorfmann/mosby3/mvi/DisposableIntentObserver.java b/mvi-common/src/main/java/com/hannesdorfmann/mosby3/mvi/DisposableIntentObserver.java
@@ -18,7 +18,7 @@
 package com.hannesdorfmann.mosby3.mvi;
 
 import io.reactivex.observers.DisposableObserver;
-import io.reactivex.subjects.PublishSubject;
+import io.reactivex.subjects.Subject;
 
 /**
  * Just a simple {@link DisposableObserver} that is used to cancel subscriptions from view's
@@ -29,21 +29,24 @@
  */
 class DisposableIntentObserver<I> extends DisposableObserver<I> {
 
-  private final PublishSubject<I> subject;
+    private final Subject<I> subject;
 
-  public DisposableIntentObserver(PublishSubject<I> subject) {
-    this.subject = subject;
-  }
+    public DisposableIntentObserver(Subject<I> subject) {
+        this.subject = subject;
+    }
 
-  @Override public void onNext(I value) {
-    subject.onNext(value);
-  }
+    @Override
+    public void onNext(I value) {
+        subject.onNext(value);
+    }
 
-  @Override public void onError(Throwable e) {
-    throw new IllegalStateException("View intents must not throw errors", e);
-  }
+    @Override
+    public void onError(Throwable e) {
+        throw new IllegalStateException("View intents must not throw errors", e);
+    }
 
-  @Override public void onComplete() {
-    subject.onComplete();
-  }
+    @Override
+    public void onComplete() {
+        subject.onComplete();
+    }
 }