[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backfeed silo mentions from other people #523

Closed
snarfed opened this issue Oct 23, 2015 · 8 comments
Closed

backfeed silo mentions from other people #523

snarfed opened this issue Oct 23, 2015 · 8 comments
Assignees
Labels

Comments

@snarfed
Copy link
Owner
snarfed commented Oct 23, 2015

e.g. if someone else tweets 'hey @username foo bar!', we'd send it as a webmention to your web site's front page. same with user mentions/tags on FB, G+, and IG.

similar to #488. inspired by #456 (comment). (thanks @singpolyma!)

@snarfed
Copy link
Owner Author
snarfed commented Nov 10, 2015

current silo support:

@snarfed
Copy link
Owner Author
snarfed commented Nov 21, 2015

one wrinkle here if that twitter @-replies usually mention the tweet's author, but they probably shouldn't get backfed to the front page as mentions.

however, if someone mentions you in a reply to someone else, that maybe should get backfed.

here's a straw man: if a mention isn't a reply, backfeed it. if it is, but it's not a reply to you, and if the tweet it's replying to doesn't mention you, backfeed it.

(other silos don't start comments with mentions by default, so they don't have this problem.)

@singpolyma
Copy link
Contributor

I'm ok with not doing the backfeed a second time for posts that are a direct reply to you. But I'd also be ok with doing it, since it still mentions you. Either way.

@snarfed snarfed self-assigned this Nov 21, 2015
@snarfed
Copy link
Owner Author
snarfed commented Nov 21, 2015

sounds good!

i'm also inclined to suppress mention backfeed when we find an original post link to one of your sites, e.g. tweets like these, so that we don't double backfeed those either.

snarfed added a commit to snarfed/granary that referenced this issue Nov 23, 2015
snarfed added a commit that referenced this issue Nov 23, 2015
…eGrSource

so that tests run the real Source.get_activities(), now that it actually does something.

for #523
@snarfed
Copy link
Owner Author
snarfed commented Nov 23, 2015

turning this on now. hold onto your britches...

snarfed added a commit that referenced this issue Nov 23, 2015
@snarfed
Copy link
Owner Author
snarfed commented Nov 23, 2015

first confirmed kill!
https://brid.gy/twitter/leitmedium#responses
https://twitter.com/nordhessenmami/status/668539086567809025

(their site doesn't accept front page webmentions, but that's fine.)

@snarfed snarfed closed this as completed Nov 23, 2015
snarfed added a commit to snarfed/granary that referenced this issue Nov 23, 2015
@snarfed
Copy link
Owner Author
snarfed commented Nov 23, 2015

example of one that did go through:

https://twitter.com/lucavgobbi/status/668762681000796160
http://www.kevinmarks.com/

(i love how @kevinmarks's use of webmention.herokuapp.com on his front page is kind of a light stress test. :P)

@dissolve
Copy link

getting these now but they don't actually refer to my URL, for example
it sent me a webmention of https://brid-gy.appspot.com/post/facebook/14305603/837135243002270 pointing to https://ben.thatmustbe.me/
but my homepage URL is missing from the generated page

snarfed added a commit to snarfed/granary that referenced this issue Dec 28, 2015
this was breaking rendering user mention URLs (snarfed/bridgy#523) for posts with non-hashtag non-person tags, e.g. links. oops!
snarfed added a commit that referenced this issue Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants