[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lighthouse account validator subcommands help text #6091

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Fix lighthouse account validator subcommands help text #6091

merged 9 commits into from
Jul 26, 2024

Conversation

chong-he
Copy link
Member

Issue Addressed

Tested and it's working, though not sure if there is an easier way of doing it

@chong-he chong-he requested a review from eserilev July 15, 2024 03:45
@chong-he chong-he added ready-for-review The code is ready for review UX-and-logs labels Jul 15, 2024
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 18, 2024
@michaelsproul
Copy link
Member

CK and I discussed a simpler approach offline (using .global(true)), so putting this on pause until we try it

@chong-he
Copy link
Member Author

CK and I discussed a simpler approach offline (using .global(true)), so putting this on pause until we try it

Thank you so much! Brings the diff to only 2 lines, tested and it's working

@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 18, 2024
@michaelsproul
Copy link
Member

Nice!

@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link
mergify bot commented Jul 18, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@AgeManning
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
mergify bot commented Jul 23, 2024

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jul 23, 2024
@mergify
Merge of #6091
38c80f8
@mergify mergify bot mentioned this pull request Jul 23, 2024
Closed
5 tasks
@chong-he chong-he added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 25, 2024
@jimmygchen
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link
mergify bot commented Jul 25, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link
mergify bot commented Jul 25, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8d175f6

mergify bot added a commit that referenced this pull request Jul 25, 2024
@mergify
Merge of #6091
a7d2072
This was referenced Jul 25, 2024
Closed
Merged
mergify bot added a commit that referenced this pull request Jul 26, 2024
@mergify
Merge of #6091
cbf3046
This was referenced Jul 26, 2024
Closed
Merged
@mergify mergify bot merged commit 8d175f6 into sigp:unstable Jul 26, 2024
27 of 28 checks passed
@chong-he chong-he mentioned this pull request Jul 26, 2024
Closed
@chong-he chong-he deleted the cli-help branch July 31, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@eserilev eserilev Awaiting requested review from eserilev

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. UX-and-logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chong-he @michaelsproul @AgeManning @jimmygchen