[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change impl Into<T> for U to impl From<U> for T #5948

Merged
merged 3 commits into from
Jun 19, 2024
Merged

chore: change impl Into<T> for U to impl From<U> for T #5948

merged 3 commits into from
Jun 19, 2024

Conversation

kevaundray
Copy link
Contributor

Issue Addressed

Following https://doc.rust-lang.org/std/convert/trait.From.html it is preferred to impl From over Into. There might be specific reasons to using Into in this repository, if so feel free to close the PR.

Proposed Changes

Please list or describe the changes introduced by this PR.

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

@michaelsproul michaelsproul added code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Jun 18, 2024
michaelsproul
michaelsproul approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member
@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! This was just a matter of tech debt, so the cleanup is much appreciated

We can also remove the clippy exception for this:

lighthouse/Makefile

Line 232 in f1d88ba

-A clippy::from-over-into \

@jimmygchen jimmygchen added the ready-for-merge This PR is ready to merge. label Jun 18, 2024
@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link
mergify bot commented Jun 18, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jun 18, 2024
@mergify
Merge of #5948
b8b3c1b
This was referenced Jun 18, 2024
Closed
Merged
Merged
@jimmygchen
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link
mergify bot commented Jun 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link
mergify bot commented Jun 19, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #5948 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jun 19, 2024
@mergify
Merge of #5948
58dfa6e
This was referenced Jun 19, 2024
Closed
Merged
mergify bot added a commit that referenced this pull request Jun 19, 2024
@mergify
Merge of #5948
b6f65ad
@mergify mergify bot mentioned this pull request Jun 19, 2024
Closed
5 tasks
mergify bot added a commit that referenced this pull request Jun 19, 2024
@mergify
Merge of #5948
265d414
This was referenced Jun 19, 2024
Closed
Merged
Merged
@jimmygchen
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link
mergify bot commented Jun 19, 2024

requeue

☑️ This pull request is already queued

@jimmygchen
Copy link
Member

@mergify unqueue

@mergify Mergify
Copy link
mergify bot commented Jun 19, 2024

unqueue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link
mergify bot commented Jun 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link
mergify bot commented Jun 19, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a87f19d

mergify bot added a commit that referenced this pull request Jun 19, 2024
@mergify
Merge of #5948
93903eb
This was referenced Jun 19, 2024
Closed
Merged
@mergify mergify bot merged commit a87f19d into sigp:unstable Jun 19, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevaundray @jimmygchen @michaelsproul @dapplion