feat: created pared-down version of User object #2499
Merged
+112
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
felangel
reviewed
Sep 27, 2024
packages/shorebird_code_push_protocol/lib/src/models/full_user.dart
Outdated
Show resolved
Hide resolved
felangel
reviewed
Sep 27, 2024
|
@felangel this is addressing the concern expressed in https://github.com/shorebirdtech/_shorebird/pull/848#discussion_r1777771115. Updated the PR description to explain better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames our current User object to "FullUser" and creates a new User object with only id, email, and display name.
This is to ensure we don't accidentally leak any sensitive information when returning user data to a different user (for example, if user A receives a response that references users B, C, etc.)
Type of Change