[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(releases): blocking UI elements that allow for adding documents to inactive releases #7879

Draft
wants to merge 5 commits into
base: corel
Choose a base branch
from
Draft

fix(releases): blocking UI elements that allow for adding documents to inactive releases #7879

wants to merge 5 commits into from
+34 −7

Conversation

jordanl17
Copy link
Member
@jordanl17 jordanl17 commented Nov 25, 2024 •
edited
Loading

Description

blockAddDocsToScheduled

What to review

Testing

Notes for release

N/A

@vercel Vercel
Copy link
vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:35am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:35am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:35am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 10:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2024 10:35am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Nov 25, 2024 •
edited
Loading

Component Testing Report Updated Nov 28, 2024 10:30 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 8s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 44s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 40s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 54s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Nov 25, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Thu, 28 Nov 2024 10:32:58 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 22.5 efps (45ms) 14.9 efps (67ms) +23ms (+50.6%) 🔴
article (body) 53.3 efps (19ms) 56.2 efps (18ms) -1ms (-5.1%) ✅
article (string inside object) 22.2 efps (45ms) 15.6 efps (64ms) +19ms (+42.2%) 🔴
article (string inside array) 20.4 efps (49ms) 14.1 efps (71ms) +22ms (+44.9%) 🔴
recipe (name) 47.6 efps (21ms) 25.0 efps (40ms) +19ms (+90.5%) 🔴
recipe (description) 55.6 efps (18ms) 27.0 efps (37ms) +19ms (+105.6%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (6ms) -1ms (-/-%) ✅
synthetic (title) 17.9 efps (56ms) 6.6 efps (153ms) +97ms (+172.3%) 🔴
synthetic (string inside object) 18.5 efps (54ms) 6.7 efps (150ms) +96ms (+176.9%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 48ms 86ms 268ms 263ms 13.9s
article (body) 19ms 22ms 31ms 91ms 342ms 6.2s
article (string inside object) 45ms 48ms 60ms 207ms 173ms 7.5s
article (string inside array) 49ms 52ms 72ms 192ms 299ms 8.0s
recipe (name) 21ms 23ms 26ms 44ms 0ms 14.8s
recipe (description) 18ms 20ms 21ms 27ms 0ms 4.5s
recipe (instructions) 7ms 9ms 11ms 45ms 0ms 3.4s
synthetic (title) 56ms 59ms 67ms 125ms 400ms 13.8s
synthetic (string inside object) 54ms 58ms 67ms 375ms 908ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 67ms 72ms 89ms 313ms 1710ms 15.4s
article (body) 18ms 21ms 26ms 143ms 454ms 6.3s
article (string inside object) 64ms 68ms 81ms 250ms 1514ms 9.8s
article (string inside array) 71ms 77ms 83ms 129ms 1727ms 10.0s
recipe (name) 40ms 43ms 45ms 60ms 127ms 9.2s
recipe (description) 37ms 39ms 42ms 56ms 26ms 6.6s
recipe (instructions) 6ms 8ms 9ms 11ms 0ms 3.2s
synthetic (title) 153ms 164ms 212ms 692ms 8264ms 24.5s
synthetic (string inside object) 150ms 156ms 174ms 946ms 7768ms 18.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 closed this Nov 27, 2024
@jordanl17 jordanl17 reopened this Nov 27, 2024
@vercel vercel bot temporarily deployed to Preview – test-next-studio November 27, 2024 15:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jordanl17