[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): remove v2 commands #5750

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

fix(cli): remove v2 commands #5750

wants to merge 1 commit into from

Conversation

bjoerge
Copy link
Member
@bjoerge bjoerge commented Feb 15, 2024

Description

Note: I originally did this as part of the work in #5533 to get rid of yarn references + old cruft, but figured it was better to consider it in a separate PR, as I'm not entirely sure whether now is the right time.

It's a "nice-to-have" cleanup and not super important and definitely not urgent.

Removes a few v2-only commands from the CLI

  • sanity uninstall
  • sanity init plugin
  • sanity init to reconfigure a v2 project
  • sanity check
  • sanity upgrade
  • sanity uninstall

What to review

  • Is there any value in having these commands around anymore?
  • Strictly strictly speaking a breaking change I guess, but these commands weren't doing much anyway, except for maybe reconfiguring a v2 project and init a v2 plugin.

Testing

n/a

Notes for release

  • Removed deprecated v2 commands from the CLI. (Note: this doesn't affect v2 end-of-life)

@bjoerge bjoerge requested a review from a team as a code owner February 15, 2024 10:42
@bjoerge bjoerge requested review from jtpetty and removed request for a team February 15, 2024 10:42
@vercel Vercel
Copy link
vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 11, 2024 6:05am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 6:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 6:05am

@socket-security Socket Security
Copy link
socket-security bot commented Feb 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@sanity/eslint-config-studio@4.0.0, npm/@sanity/eventsource@5.0.1, npm/@sanity/generate-help-url@3.0.0, npm/@sanity/google-maps-input@4.0.1, npm/@sanity/icons@2.11.8, npm/@sanity/image-url@1.0.2, npm/@sanity/locale-ko-kr@1.1.3, npm/@sanity/locale-nb-no@1.1.4, npm/@sanity/locale-nn-no@1.1.5, npm/@sanity/locale-pt-pt@1.1.2, npm/@sanity/locale-sv-se@1.2.3, npm/@sanity/logos@2.1.10, npm/@sanity/pkg-utils@6.1.0, npm/@sanity/presentation@1.11.4, npm/@sanity/presentation@1.12.3, npm/@sanity/preview-url-secret@1.6.7, npm/@sanity/react-loader@1.9.9, npm/@sanity/telemetry@0.7.7, npm/@sanity/test@0.0.1-alpha.1, npm/@sanity/ui-workshop@1.2.11, npm/@sanity/ui@2.1.2, npm/@sanity/uuid@3.0.2, npm/@sanity/visual-editing@1.8.7, npm/@tanstack/react-virtual@3.0.0-beta.54, npm/@testing-library/jest-dom@6.4.2, npm/@testing-library/react@13.4.0, npm/@testing-library/user-event@13.5.0, npm/@turf/helpers@6.5.0, npm/@turf/points-within-polygon@5.1.5, npm/@types/archiver@6.0.2, npm/@types/arrify@1.0.4, npm/@types/arrify@2.0.1, npm/@types/babel__core@7.20.5, npm/@types/babel__generator@7.6.8, npm/@types/babel__register@7.17.3, npm/@types/babel__traverse@7.20.5, npm/@types/configstore@5.0.1, npm/@types/connect-history-api-fallback@1.5.4, npm/@types/cpx@1.5.5, npm/@types/debug@4.1.12, npm/@types/decompress@4.2.7, npm/@types/express-ws@3.0.4, npm/@types/express@4.17.21, npm/@types/glob@7.2.0, npm/@types/inquirer@6.5.0, npm/@types/jsdom@20.0.1, npm/@types/lodash@4.17.0, npm/@types/log-symbols@2.0.0, npm/@types/minimist@1.2.5, npm/@types/moment@2.13.0, npm/@types/node-ipc@9.2.3, npm/@types/node@18.19.29, npm/@types/object-inspect@1.13.0, npm/@types/raf@3.4.3, npm/@types/react-copy-to-clipboard@5.0.7, npm/@types/react-dom@18.2.24, npm/@types/react-is@18.2.4, npm/@types/react@18.2.75, npm/@types/refractor@3.4.1, npm/@types/resolve-from@4.0.0, npm/@types/rimraf@3.0.2, npm/@types/semver-compare@1.0.3, npm/@types/semver@6.2.7, npm/@types/semver@7.5.8, npm/@types/shallow-equals@1.0.3, npm/@types/speakingurl@13.0.6, npm/@types/tar-fs@2.0.4, npm/@types/tar-stream@3.1.3, npm/@types/tar@6.1.11, npm/@types/three@0.150.2, npm/@types/use-sync-external-store@0.0.6, npm/@types/validate-npm-package-name@3.0.3, npm/@types/which@2.0.2, npm/@types/ws@8.5.10, npm/@types/yargs@17.0.32, npm/@typescript-eslint/eslint-plugin@7.5.0, npm/@typescript-eslint/parser@7.5.0, npm/@uiw/react-codemirror@4.21.25, npm/@vercel/frameworks@1.6.0, npm/@vercel/fs-detectors@4.1.3, npm/@vercel/stega@0.1.0, npm/@vitejs/plugin-react@4.2.1, npm/archiver@7.0.1, npm/arrify@2.0.1, npm/async-mutex@0.4.1, npm/boxen@4.2.0, npm/cac@6.7.14, npm/chalk@4.1.2, npm/chokidar@3.6.0, npm/clean-stack@3.0.1

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 15, 2024 •
edited
Loading

Component Testing Report Updated Apr 11, 2024 6:08 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 24s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@bjoerge bjoerge requested a review from rexxars February 15, 2024 12:01
@rexxars
Copy link
Member
rexxars commented Feb 15, 2024

I personally feel this should wait until v2 EOL, as I do not see the immediate urgency in this, and it is easier to communicate.

@bjoerge bjoerge marked this pull request as draft February 16, 2024 07:48
@bjoerge @rexxars
fix(cli): remove v2 commands
ca6550e 
- remove sanity uninstall command (v2 only)
- remove sanity init plugin command (v2 only)
@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/core-js@2.6.12
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"
  • orphan: npm/core-js@2.6.12

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/core-js@2.6.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoerge @rexxars