[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull me #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pull me #21

wants to merge 1 commit into from

Conversation

pramod21kadam
Copy link

if a number is >= 20000000 then decrease the number by one And make a recursive call and LET THE STACK OVERFLOWWWWWWWWW!!!!!!!!!!!!

… recursive call and LET THE STACK OVERFLOWWWWWWWWW!!!!!!!!!!!!
Copy link
@joseywoermann joseywoermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -40,6 +40,10 @@ function isOdd(number){
else if (number < 20000000 && number > 18000000){
return twentyMil(number);
}
else{
number = number - 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is literally incorrect: it should be subtracting 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants