[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshot hash logic comparison #12

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Update snapshot hash logic comparison #12

merged 1 commit into from
Mar 21, 2022

Conversation

aancw
Copy link
Contributor
@aancw aancw commented Mar 21, 2022 •
edited
Loading

Update snapshot hash logic comparison. So, whenever we add more snapshot hash version, we can just add the hash value and version. No need to more if else. Follow the DRY principles.

Also, update the gitignore for python project

@aancw
Update snapshot hash logic
21557fe 
Update snapshot hash logic comparison. So, whenever we add more snapshot hash version, we can just add the hash value and version. No need to more if else.
rscloura
rscloura approved these changes Mar 21, 2022
View reviewed changes
Copy link
Owner
@rscloura rscloura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a much more elegant way to handle the various versions! Thanks for the PR!

@rscloura rscloura merged commit 660335c into rscloura:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rscloura rscloura rscloura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aancw @rscloura