Addons: remove old X-RTD-Hosting-Integrations HTTP header
#11653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
approved these changes
Oct 7, 2024
|
We can move the removal of that particular test to another PR if we want, so we can merge that removal quicker. |
humitos
added a commit
that referenced
this pull request
Oct 7, 2024
This header is useless now that we are fully migrated to Addons. I'm removing the only the test for now, since it's failing on all the PRs. Related #11653
stsewd
pushed a commit
that referenced
this pull request
Oct 7, 2024
This header is useless now that we are fully migrated to Addons. I'm removing the only the test for now, since it's failing on all the PRs. Related #11653
|
I'm adding this PR to the next sprint since we are all already in addons. Besides updating this PR, we will want to remove the this header from the CF worker as well. |
humitos
added a commit
to readthedocs/common
that referenced
this pull request
Nov 11, 2024
This header was used for `build.commands` when we were testing addons on those projects that were using our own Sphinx extension to inject the flyout. That is not required anymore since we have all the projects using the new addons now. Related readthedocs/readthedocs.org#11653 Closes #223
ericholscher
approved these changes
Nov 11, 2024
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
humitos
added a commit
to readthedocs/common
that referenced
this pull request
Nov 12, 2024
* CF Worker: remove unused `X-RTD-Hosting-Integrations` HTTP header This header was used for `build.commands` when we were testing addons on those projects that were using our own Sphinx extension to inject the flyout. That is not required anymore since we have all the projects using the new addons now. Related readthedocs/readthedocs.org#11653 Closes #223 * Remove header from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old HTTP header used by
build.commands. All the projects are using the new addons now, so this header is not used anymore.