[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default count in CountDownLatch to 1 #251

Merged
merged 1 commit into from
Feb 24, 2015

Conversation

tenderlove
Copy link
Contributor

it's very common to use a CountDownLatch with a count of 1. Default
count to 1 so that users can just call new and get a valid object
with a count of 1.

I'd like to use this to replace the Latch implementation in Rails.

it's very common to use a CountDownLatch with a count of 1.  Default
`count` to 1 so that users can just call `new` and get a valid object
with a count of 1.
@jdantonio
Copy link
Member

Thank you for the PR! Please let us know if there are other features you'd like to see.

The failed tests are unrelated to this PR and and known to be buggy tests (Issue #117).

jdantonio added a commit that referenced this pull request Feb 24, 2015
default `count` in CountDownLatch to 1
@jdantonio jdantonio merged commit c3d47b2 into ruby-concurrency:master Feb 24, 2015
@tenderlove
Copy link
Contributor Author

@jdantonio thank you!

@jdantonio jdantonio mentioned this pull request Mar 1, 2015
34 tasks
@pitr-ch pitr-ch added the enhancement Adding features, adding tests, improving documentation. label Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding features, adding tests, improving documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants