Add events to API calls #2130
Merged
Add events to API calls #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you still add a changelog? |
fsimonis
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Great! Let's merge and see how it behaves in large cases.
We may have to remove the event for setting an individual vertex for performance reasons.
Reading events file profiling.json
Output timing are in us.
name │ sum count mean min max
─────────────────────────────────────────────────────────────────┼──────────────────────────────────────────────────────────
total │ 2079587.0 1 2079587.0 2079587.0 2079587.0
solver.advance │ 4878.0 849 5.745583038869258 4.0 22.0
readData.Solid-Nodes-Mesh_Pressure │ 506.0 848 0.5966981132075472 0.0 2.0
writeData.Solid-Nodes-Mesh_CrossSectionLength │ 330.0 848 0.3891509433962264 0.0 1.0
solver.initialize │ 18.0 1 18.0 18.0 18.0
setMeshVertices.Solid-Nodes-Mesh │ 3.0 1 3.0 3.0 3.0
writeData.Solid-Nodes-Mesh_CrossSectionLength │ 1.0 1 1.0 1.0 1.0
---- >8 ====
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Added profiling Events to more API functions.
Motivation and additional information
Close #2013
Author's checklist
pre-commithook to prevent dirty commits and usedpre-commit run --allto format old commits.make changelogif there are user-observable changes since the last release.Reviewers' checklist