[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed client copy mutation, cleanup up move mutation for consistency #6349

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

pnicolli
Copy link
Contributor

No description provided.

Copy link
netlify bot commented Sep 27, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit ca3936a
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66f6dc0ccf011c00086059c5

@ichim-david
Copy link
Member

@pnicolli @sneridagh it seems that the path needs to be allowed to be set for these crud operations, I noticed another pull request added https://github.com/plone/volto/pull/6301/files#diff-ca875ccb3b13f54d06884d6a8d9a696d1d331322bcc0c06ef618e083ce147eb4R11 that does something similar to Pierro's pull request but for querystring-search.

Copy link
Member
@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ichim-david do you think that this collides with the PR you mention? Or you wanted to raise attention to the other as well?

@ichim-david
Copy link
Member

LGTM

@ichim-david do you think that this collides with the PR you mention? Or you wanted to raise attention to the other as well?

Just raised awareness that it seems that the path needs to be added in several places

@pnicolli
Copy link
Contributor Author
pnicolli commented Oct 2, 2024

Just raised awareness that it seems that the path needs to be added in several places

Yeah that's true, these will need to be fixed as we start using the library.

@sneridagh sneridagh merged commit ff84416 into main Oct 2, 2024
70 checks passed
@sneridagh sneridagh deleted the fix-client-copy-mutation branch October 2, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants