Allow exporting via signed URL #4666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 1 of 403 screens tested: view and approve differences detected. Last updated for commit 4dc5e7d. This comment will update as new commits are pushed. |
This patch deprecates the pprof report type for a more generic export type, which both extends the functionality to allow for more formats to be possible in the future as well as allow either serving the download content inline in the response like the pprof report does, or if Parca is configured this way, then upload the export to object storage and serve a download URL that is a signed URL from object storage.
1161bc4
to
2117505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deprecates the pprof report type for a more generic export type, which both extends the functionality to allow for more formats to be possible in the future as well as allow either serving the download content inline in the response like the pprof report does, or if Parca is configured this way, then upload the export to object storage and serve a download URL that is a signed URL from object storage.