[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): remove parent beacon root from conversion functions #10090

Merged
merged 3 commits into from
Aug 5, 2024
Merged

chore(rpc): remove parent beacon root from conversion functions #10090

merged 3 commits into from
Aug 5, 2024
+17 −20

Conversation

rkrasiuk
Copy link
Member
@rkrasiuk rkrasiuk commented Aug 5, 2024

Description

Remove parent beacon root from return type of conversion functions. Keep the interface same between all of the conversion functions.

@rkrasiuk rkrasiuk added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Aug 5, 2024
@rkrasiuk rkrasiuk requested a review from fgimenez as a code owner August 5, 2024 15:08
Rjected
Rjected approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member
@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mattsse
mattsse approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, the caller should just do that this is how we do it in try_into_block anyway

@rkrasiuk rkrasiuk enabled auto-merge August 5, 2024 15:25
@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 5a8a7bc Aug 5, 2024
32 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/remove-parent-beacon-root-from-conversion-fns branch August 5, 2024 15:49
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@rkrasiuk @martinezjorge
chore(rpc): remove parent beacon root from conversion functions (para…
402335c 
…digmxyz#10090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @Rjected @mattsse