[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add better engine insert block error type #9884

Merged
merged 1 commit into from
Jul 30, 2024
Merged

feat: add better engine insert block error type #9884

merged 1 commit into from
Jul 30, 2024

Conversation

Rjected
Copy link
Member
@Rjected Rjected commented Jul 29, 2024 •
edited
Loading

Introduces an error type that can be used in the new engine, to distinguish between invalid blocks and other types of errors

depends on #9911

@Rjected Rjected added C-enhancement New feature or request A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Jul 29, 2024
@Rjected Rjected mentioned this pull request Jul 30, 2024
Merged
@Rjected Rjected force-pushed the dan/add-engine2-insert-block-error branch 5 times, most recently from 77cc7de to df48c8c Compare July 30, 2024 22:04
@Rjected
Copy link
Member Author
Rjected commented Jul 30, 2024

Marking this ready for review. Would like naming recommendations

@Rjected Rjected marked this pull request as ready for review July 30, 2024 22:06
@Rjected
feat: better insert block engine error type
ec2330f 
finish fatal error / invalid block result fn

use second insert block error in new tree

cargo fmt

remove TODO
@Rjected Rjected force-pushed the dan/add-engine2-insert-block-error branch from df48c8c to ec2330f Compare July 30, 2024 22:10
mattsse
mattsse approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the naming because temp.

this should unblock us from debugging more engine API stuff

@Rjected Rjected added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit a90fc90 Jul 30, 2024
32 checks passed
@Rjected Rjected deleted the dan/add-engine2-insert-block-error branch July 30, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse