chore: add static file helpers on StorageWriter #9740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jul 23, 2024
| first_tx_index = Some(0); | ||
| } | ||
|
|
||
| // TODO: I guess this error will never be returned |
There was a problem hiding this comment.
unclear what this todo means
| td: U256, | ||
| ) -> ProviderResult<u64> { | ||
| debug!(target: "tree::persistence", ?td, ?start_tx_number, "Logging transactions"); | ||
| fn log_transactions(&self, block: Arc<SealedBlock>) -> ProviderResult<u64> { |
There was a problem hiding this comment.
I find log_ very confusing can we stick to write ?
mattsse
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some helper methods to write headers / transactions to static files, similar to the
append_receipts_from_blocksmethod, inStorageWriter. This makes thelog_transactionsmethod basically a wrapper overStorageWritermethods now