[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move metrics to its own crate #9691

Merged
merged 12 commits into from
Jul 25, 2024
Merged

feat: move metrics to its own crate #9691

merged 12 commits into from
Jul 25, 2024
+711 −462

Conversation

loocapro
Copy link
Contributor

Closes #9458

mattsse
mattsse requested changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, pedantic nits

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
crates/node/metrics/Cargo.toml Outdated Show resolved Hide resolved
crates/node/core/Cargo.toml Show resolved Hide resolved
@loocapro loocapro marked this pull request as ready for review July 23, 2024 08:41
@loocapro loocapro requested a review from mattsse July 23, 2024 08:42
mattsse
mattsse requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, some layout issues remain,

think of the metrics crate as something that gets all the things it uses as input, this way we don't need the buildscript etc.

crates/node/metrics/build.rs Outdated Show resolved Hide resolved
crates/node/core/Cargo.toml Outdated Show resolved Hide resolved
crates/node/metrics/src/version_metrics.rs Show resolved Hide resolved
crates/node/metrics/src/version_metrics.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 23, 2024
@loocapro loocapro requested a review from mattsse July 23, 2024 17:26
onbjerg
onbjerg previously requested changes Jul 24, 2024
View reviewed changes
Copy link
Member
@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! one small nit

crates/node/metrics/src/recorder.rs Outdated Show resolved Hide resolved
@loocapro loocapro requested a review from onbjerg July 25, 2024 09:02
mattsse
mattsse requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last pedantic doc nit and needs rebase

crates/cli/commands/src/stage/run.rs Show resolved Hide resolved
crates/node/metrics/src/server.rs Outdated Show resolved Hide resolved
@loocapro loocapro requested a review from mattsse July 25, 2024 10:21
@mattsse mattsse changed the title Metrics to its own crate feat: move metrics to its own crate Jul 25, 2024
@mattsse mattsse added this pull request to the merge queue Jul 25, 2024
Merged via the queue into paradigmxyz:main with commit 93ebdf2 Jul 25, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract metrics module from node-core to its own crate
3 participants
@loocapro @onbjerg @mattsse