[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: raw_tx_by_hash #6827

Merged
merged 6 commits into from
Mar 1, 2024
Merged

feat: raw_tx_by_hash #6827

merged 6 commits into from
Mar 1, 2024

Conversation

loocapro
Copy link
Contributor
@loocapro loocapro commented Feb 27, 2024 •
edited
Loading

Closes: #6760

  • eth_getRawTransactionByBlockHashAndIndex
  • eth_getRawTransactionByBlockNumberAndIndex

mattsse
mattsse requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'd prefer keeping the transaction_by_hash

and instead having a new raw_transaction_by_hash() -> PooledTransactionElement

because for these endpoints we don't need the metadata for mined txs, I'm fine with duplicating some code here

crates/rpc/rpc/src/eth/api/transactions.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the A-rpc Related to the RPC implementation label Feb 27, 2024
@mattsse mattsse marked this pull request as ready for review February 27, 2024 19:23
@mattsse
Copy link
Collaborator
mattsse commented Feb 27, 2024

@loocapro for the historical eth_getRawTransactionByBlockHash* calls we can simply reuse the existing transaction_by_hash functions because we don't expect the 4844 sidecar here anymore

@loocapro loocapro requested a review from mattsse March 1, 2024 16:24
mattsse
mattsse requested changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator
@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic nit

crates/rpc/rpc/src/eth/api/transactions.rs Outdated Show resolved Hide resolved
@loocapro @mattsse
Update crates/rpc/rpc/src/eth/api/transactions.rs
65ce904 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@mattsse mattsse added this pull request to the merge queue Mar 1, 2024
Merged via the queue into paradigmxyz:main with commit 2009784 Mar 1, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more eth_ getraw transactions functions
2 participants
@loocapro @mattsse