[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove proptest specific encoding logic #6503

Merged
merged 22 commits into from
Feb 28, 2024
Merged

remove proptest specific encoding logic #6503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cc9a5bd
update
Feb 9, 2024
6f453c6
fix : macro error
Feb 11, 2024
9ab5be4
nit
Feb 11, 2024
2b5e8d6
update
Feb 12, 2024
a183703
use manual arbitrary impls at various structs which use Header
Feb 13, 2024
15b6702
nits
Feb 23, 2024
e14b87a
clippy
Feb 23, 2024
6bef07d
use custom header test in SealedBlock::arbitrary also
Feb 23, 2024
60bed53
flatten if else
Feb 23, 2024
6ccf5da
clip
Feb 23, 2024
67293c1
collapsable if else
Feb 23, 2024
f73d48b
clippy
Feb 23, 2024
003ba7e
nits
Feb 24, 2024
c6b582a
add_arbitrary_tests rlp add
Feb 24, 2024
98c11ab
use valid header strategy only
Feb 24, 2024
2d85dd9
missed a collapsible if to be changed
Feb 24, 2024
0f4f2cd
nits
Feb 26, 2024
4d5dda7
chore: fix cargo hack check
Rjected Feb 28, 2024
d9087cc
cleanup and derive more
Rjected Feb 28, 2024
868b704
reusable strategy and generation method
Rjected Feb 28, 2024
aaeb562
feature gate imports
Rjected Feb 28, 2024
1a4c544
format
Rjected Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix cargo hack check
  • Loading branch information
@Rjected
Rjected committed Feb 28, 2024
commit 4d5dda7d13ccdf4a98ddb06cd226a86c03d815c0
8 changes: 3 additions & 5 deletions crates/primitives/src/block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pub struct Block {
#[cfg(any(test, feature = "arbitrary"))]
impl proptest::arbitrary::Arbitrary for Block {
type Parameters = ();
type Strategy = BoxedStrategy<Self>;
type Strategy = proptest::prelude::BoxedStrategy<Self>;

fn arbitrary_with(_: Self::Parameters) -> Self::Strategy {
use proptest::{collection::vec, prelude::*};
Expand Down Expand Up @@ -337,7 +337,7 @@ pub struct SealedBlock {
#[cfg(any(test, feature = "arbitrary"))]
impl proptest::arbitrary::Arbitrary for SealedBlock {
type Parameters = ();
type Strategy = BoxedStrategy<Self>;
type Strategy = proptest::prelude::BoxedStrategy<Self>;

fn arbitrary_with(_: Self::Parameters) -> Self::Strategy {
use proptest::{collection::vec, prelude::*};
Expand Down Expand Up @@ -724,12 +724,10 @@ impl<'a> arbitrary::Arbitrary<'a> for BlockBody {
}
}

use proptest::prelude::BoxedStrategy;

#[cfg(any(test, feature = "arbitrary"))]
impl proptest::arbitrary::Arbitrary for BlockBody {
type Parameters = ();
type Strategy = BoxedStrategy<Self>;
type Strategy = proptest::prelude::BoxedStrategy<Self>;

fn arbitrary_with(_: Self::Parameters) -> Self::Strategy {
use proptest::{collection::vec, prelude::*};
Expand Down
1 change: 1 addition & 0 deletions crates/primitives/src/header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,7 @@ impl proptest::arbitrary::Arbitrary for SealedHeader {
type Strategy = proptest::strategy::BoxedStrategy<SealedHeader>;
}

#[cfg(any(test, feature = "arbitrary"))]
impl<'a> arbitrary::Arbitrary<'a> for SealedHeader {
fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
// Directly generate values for Header and BlockHash using Unstructured
Expand Down
Loading