New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd.RangeIndex should accept range as the first argument #686

Closed

kshitiz305 wants to merge 0 commits into pandas-dev:main from kshitiz305:main

Contributor

kshitiz305 commented

Closes pd.RangeIndex should accept range as the first argument #677 (Replace xxxx with the Github issue number)
Tests added: Please use assert_type() to assert the type of any return value

Dr-Irv requested changes

View reviewed changes

Collaborator

Dr-Irv left a comment

Can you add a test to tests/test_indexes.py that instantiates a RangeIndex with a range argument, using check and assert_type as in other tests?

pandas-stubs/_version.pyi Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

Contributor Author

kshitiz305 commented

Can you add a test to tests/test_indexes.py that instantiates a RangeIndex with a range argument, using check and assert_type as in other tests?

let me push the code with the required test.

Collaborator

Dr-Irv commented

@kshitiz305 checking on status of this PR

Contributor Author

kshitiz305 commented

@Dr-Irv Kindly have a look test for the range have been pushed

Collaborator

Dr-Irv commented

So there is a failure because pyright 1.1.309 started finding a whole bunch of issues. Trying to figure out what version to pin pyright to so things will work

Dr-Irv mentioned this pull request

pin pyright to 1.1.308 #709

Merged

Collaborator

Dr-Irv commented

Once #709 is merged, you will need to merge that in and revert changes to the 2 files I indicated.

Collaborator

Dr-Irv commented

@kshitiz305 #709 has been merged, so can you merge with main, fix the reported issues, and push, then we can run the tests to see if everything works

Dr-Irv requested changes

View reviewed changes

pandas-stubs/_version.pyi Outdated Show resolved Hide resolved

pyproject.toml Outdated

@@ @@ -1,6 +1,6 @@ @@
               [tool.poetry]
               name = "pandas-stubs"
-              version = "2.0.1.230501"
+              version = "2.0.1.230507"

Collaborator

Dr-Irv

Please revert this change.

Member

twoertwein

I think you can simply run git checkout <commit hash from before you made any changes> pandas-stubs/_version.pyi pyproject.toml to revert these two files to what they were before.

pandas-stubs/core/indexes/range.pyi Outdated Show resolved Hide resolved

kshitiz305 force-pushed the main branch from bd5d16a to 3ec68c1 Compare

June 2, 2023 07:40

Dr-Irv requested changes

View reviewed changes

Collaborator

Dr-Irv left a comment

You also should do poetry run poe style before the next push, as the CI is failing because of that.

pandas-stubs/core/indexes/range.pyi Outdated Show resolved Hide resolved

tests/test_indexes.py Outdated Show resolved Hide resolved

Contributor Author

kshitiz305 commented

@Dr-Irv commit 6d89c40

Could you help me with this if this shall include the new or __ init__ as this is leading a confusion and also failing pyright

Dr-Irv requested changes

View reviewed changes

pandas-stubs/core/indexes/range.pyi Outdated

                   def __init__(
-                      self,
-                      start: int | RangeIndex = ...,
+                      cls,

Collaborator

Dr-Irv

This should be self, because it is in __init__()

I think this is the cause of the pyright error you are getting.

Collaborator

Dr-Irv commented

@kshitiz305 can you merge with main and get this finished up?

kshitiz305 closed this

kshitiz305 force-pushed the main branch from 5b0d8a0 to 6bb1215 Compare

September 6, 2023 09:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet