TST (string dtype): un-xfail string tests specific to object dtype #59433
Conversation
| np.array([f"foo_{i}" for i in range(1000)], dtype=object), | ||
| ), | ||
| ( | ||
| ht.StringHashTable, |
There was a problem hiding this comment.
I thought we added a hashtable for strings that didn't use Python objects. @phofl am I misremembering?
There was a problem hiding this comment.
@WillAyd the StringHashTable is string specific, but still takes an object dtype array with Python strings as input (it just assumes the array only contains strings, and not any random Python object)
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Still active |
|
Thanks @jbrockmendel |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…andas-dev#59433) Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> (cherry picked from commit dbeeb1f)
|
Manual backport -> #60180 |
xref #54792