add ShrinkTo to ppf and remove some CodecInOut in passes_test #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after this there are only 11 uses of |
szabadka
reviewed
Sep 27, 2024
|
|
||
| // Copy data row by row | ||
| for (size_t y = 0; y < new_ysize; ++y) { | ||
| memcpy(reinterpret_cast<uint8_t*>(new_pixels.get()) + y * new_stride, |
There was a problem hiding this comment.
why do we need to reallocate + copy here? wouldn't leaving stride as is and just setting xsize/ysize to the new values work?
There was a problem hiding this comment.
I guess yes, but I thought after we reallocate and copy here, less memory is used.
There was a problem hiding this comment.
In the CodecIO/ImageF case we only set the new size, and don't reallocate. I think the idea was that this operation should be cheap.
Since this is only used in tests, one more reason to just set the new size is to find any cases where we incorrectly assume that stride = xsize * pixel_stride_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.