Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1269.
Since
lz4/programs/Makefile:SRCFILES
explicitly contains source code oflz4
CLI andliblz4
,CMakeLists.txt
must follow this settings.It also means,
lz4
CLI and legacylz4c
must avoid to link withliblz4
.This PR supports the following two expected scenarios: shared and static lib.
I'll add these scenarios to the CI as a follow up PR.