[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant error check #1224

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

Nicoshev
Copy link
Contributor
@Nicoshev Nicoshev commented Apr 8, 2023

Within LZ4_decompress_generic, on line 2061, the following error condition is checked:

(checkOffset) && (unlikely(match + dictSize < lowPrefix))

Any of the two code branches that follow also check such condition, so it should be safe to remove it.

Copy link
Member
@Cyan4973 Cyan4973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds reasonable

@Cyan4973 Cyan4973 merged commit a69683f into lz4:dev Sep 10, 2023
@Nicoshev Nicoshev deleted the remove_redundant_code branch January 14, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants