[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid computing 0 offsets from null pointers #884

Merged
merged 1 commit into from
Jul 8, 2020
Merged

avoid computing 0 offsets from null pointers #884

merged 1 commit into from
Jul 8, 2020

Conversation

emaxerrno
Copy link
Contributor

Similar work in the kernel:
https://patchwork.kernel.org/patch/11351499/

UBsan (+clang-10) complains about doing pointer arithmetic (adding 0)
to a nullpointer.

This patch is tested with clang-10+ubsan

@emaxerrno
avoid computing 0 offsets from null pointers
e68c7d3 
Similar work in the kernel:
https://patchwork.kernel.org/patch/11351499/

UBsan (+clang-10) complains about doing pointer arithmetic (adding 0)
to a nullpointer.

This patch is tested with clang-10+ubsan
@emaxerrno
Copy link
Contributor Author

The freebsd CI seems like it's having issues, unrelated to the patch

pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2
pkg: Repository FreeBSD load error: meta cannot be loaded No error: 0
Unable to open created repository FreeBSD
Unable to update repository FreeBSD
Error updating repositories!```

@Cyan4973
Copy link
Member
Cyan4973 commented Jul 8, 2020

Yes, don't worry about the CI, this test has proven flacky in the past, so no surprise here.

@Cyan4973 Cyan4973 merged commit 6b12fde into lz4:dev Jul 8, 2020
@emaxerrno
Copy link
Contributor Author

thank you for the time & for reviewing so quickly! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emaxerrno @Cyan4973